Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LifecycleScopeType.md #615

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Update LifecycleScopeType.md #615

merged 5 commits into from
Jan 31, 2024

Conversation

kestewart
Copy link
Contributor

@kestewart kestewart commented Jan 29, 2024

Update the descriptions for the LifecycleScopedRelationship Enumerations.

Note that this parameterizes historical relationships, like DEV_DEPENDENCY_OF, BUILD_DEPENENCY_OF, RUNTIME_DEPENDENCY_OF, etc. and pelaces them with depends_on with this lifecycleScopeType.

Signed-off-by: Kate Stewart kstewart@linuxfoundation.org

Update the descriptions for the LifecycleScopedRelationship Enumerations.  

Note that this parameterizes historical relationships, like DEV_DEPENDENCY_OF, BUILD_DEPENENCY_OF, RUNTIME_DEPENDENCY_OF, etc. and pelaces them with depends_on with this lifecycleScopeType.
@kestewart kestewart added this to the 3.0-rc2 milestone Jan 29, 2024
@kestewart kestewart mentioned this pull request Jan 29, 2024
20 tasks
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A set of suggestions to make the language more consistent by referring to the "phase" of the lifecycle in the enumeration comments.

model/Core/Vocabularies/LifecycleScopeType.md Outdated Show resolved Hide resolved
model/Core/Vocabularies/LifecycleScopeType.md Outdated Show resolved Hide resolved
model/Core/Vocabularies/LifecycleScopeType.md Outdated Show resolved Hide resolved
model/Core/Vocabularies/LifecycleScopeType.md Outdated Show resolved Hide resolved
@goneall goneall mentioned this pull request Jan 30, 2024
32 tasks
kestewart and others added 4 commits January 30, 2024 11:33
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
@kestewart
Copy link
Contributor Author

@goneall - I don't really think "phase" is really needed, but I don't feel strongly enough to argue. Applied your changes. Can you please re-review.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kestewart kestewart merged commit d901a18 into main Jan 31, 2024
1 check passed
@kestewart kestewart deleted the kestewart-patch-2 branch January 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants