-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LifecycleScopeType.md #615
Conversation
Update the descriptions for the LifecycleScopedRelationship Enumerations. Note that this parameterizes historical relationships, like DEV_DEPENDENCY_OF, BUILD_DEPENENCY_OF, RUNTIME_DEPENDENCY_OF, etc. and pelaces them with depends_on with this lifecycleScopeType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A set of suggestions to make the language more consistent by referring to the "phase" of the lifecycle in the enumeration comments.
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
@goneall - I don't really think "phase" is really needed, but I don't feel strongly enough to argue. Applied your changes. Can you please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the descriptions for the LifecycleScopedRelationship Enumerations.
Note that this parameterizes historical relationships, like DEV_DEPENDENCY_OF, BUILD_DEPENENCY_OF, RUNTIME_DEPENDENCY_OF, etc. and pelaces them with depends_on with this lifecycleScopeType.
Signed-off-by: Kate Stewart kstewart@linuxfoundation.org